Skip to content

Rewrite mutable.Set/Map no longer have a + operation #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2018

Conversation

MasseGuillaume
Copy link
Contributor

@MasseGuillaume MasseGuillaume commented Jun 22, 2018

Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Can you add a few more cases in the input file? (just to check that we don’t miss some corner cases)

@MasseGuillaume
Copy link
Contributor Author

Yup it will require this fix: 4c51cf3

@MasseGuillaume
Copy link
Contributor Author

hum, actually it's fine. I did not find any counter examples.

@julienrf
Copy link
Contributor

Can you still add the examples to the input file? Also you have to resolve the conflict (I know this is boring…)

@MasseGuillaume
Copy link
Contributor Author

@julienrf good to go.

@julienrf julienrf merged commit 5fe1aaa into scala:master Jun 22, 2018
martijnhoekstra pushed a commit to martijnhoekstra/scala-collection-compat that referenced this pull request Nov 9, 2022
New scala-module-plugin with sbt-ci-release / travisci / dynver / header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants